Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding section that details API Endpoints by Component #384

Merged
merged 36 commits into from
Jun 4, 2024

Conversation

eric-schuh
Copy link
Collaborator

@eric-schuh eric-schuh commented May 14, 2024

This PR looks to resolve #285

A section has been added to the "The VC API " section of the document called "API Component Overview". This section summarizes all endpoints in the VC-API, grouping them by the component the endpoint is expected to live on, along with a table for each of these components that lists the API endpoint, as well as the component that is the expected caller of the endpoint.

The workflow/exchanges endpoints are not currently indexed but should be added after the following PR is completed:
#382


Preview | Diff

eric-schuh added 30 commits May 14, 2024 09:39
Adding fields to support new tables by endpoints
added new fields to support new tables by compenent
added new fields to support new tables by component
adding new tables by component
added more descriptive language to component table section
added function to build the component tables
testing swagger
testing swagger
updated yaml to use the servers property of the various post/get/delete openapi specifiction
updated to use server parameter
swapped to using server parameter
updated buildComponentTables to use the servers parameter
fixing spelling
fixing some language
adding server parameter to paths
fixed error if specified path is not defined in the yaml currently
@eric-schuh
Copy link
Collaborator Author

From review on 5/14 call:

  • Currently the way the auto generation is working the "server" parameter from the OAS3.0.0 specification, we want to shift to using an x-parameter
  • What this has caused is that some endpoints like /credentials which exist on multiple components at this point have overloaded expected callers
  • Do we want to add descriptions to these tables? Currently the endpoint descriptions live in the Issuing/Verifying/Presenting sections of the document

@eric-schuh
Copy link
Collaborator Author

Updated to use the new parameter x-expectedCaller in yml files, also added x-expectedCaller to the new exchanges.yml endpoints.

@eric-schuh eric-schuh merged commit cb6494c into w3c-ccg:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API endpoints MUST specify the component (Issuer App, Issuer Service, etc.)
1 participant