Add general discussion of options.
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes-smith
requested review from
msporny,
mavarley and
mkhraisha
as code owners
TallTed
suggested changes
Feb 27, 2024
dlongley
approved these changes
Feb 27, 2024
dlongley
reviewed
Feb 27, 2024
msporny
reviewed
Feb 27, 2024
index.html
Outdated
| None of the properties in `options` are required for any endpoint, as these properties | ||
| are intended to meet per-configuration needs that may vary. However, configuration may | ||
| prohibit some options from being used in order to preclude clients from passing certain | ||
| data to a given configuration. |
There was a problem hiding this comment.
Suggested change
| data to a given configuration. | |
| data to a given instance. |
Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Dave Longley <[email protected]>
msporny
approved these changes
Feb 27, 2024
msporny
reviewed
Feb 27, 2024
TallTed
reviewed
Feb 28, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
mkhraisha
approved these changes
Mar 5, 2024
msporny
reviewed
Mar 5, 2024
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add section explicitly stating that properties in
optionsare not required for any endpoint, but that configuration may disallow clients from using specific options.Preview | Diff