This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Fix #201 and #56 -- Added support for public keys as Ethereum addresses #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2019 16:40
added support for ethereumAddress.
peacekeeper
reviewed
May 30, 2019
peacekeeper
approved these changes
May 30, 2019
brentzundel
approved these changes
May 30, 2019
|
Per discussion in 2019-05-30 DID Spec and DID Resolution Spec meeting, @awoie will update this PR to say that a public key property MUST be in the Linked Data Cryptographic Suite Registry. |
|
@peacekeeper @rhiaro updated the PR and I hope that resolves the issue. (updated) Please note, the information in the note section refers to what the SSI community has in use rather than the registry itself. This is reasonable as the registry is not well maintained atm (but we want to change that) and as far as I know some of the other public key properties are not yet included as well, e.g., publicKeyJwk. |
|
Merging per decision in 2019-06-06 DID Spec and DID Resolution Spec meeting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the immediate need to support public keys as Ethereum addresses and removes constraints on public keys in general. This will ensure that any entry in the referenced registry (once final) can be used to describe the key types and formats.
Preview | Diff