Fix: toExpression handles double quotes in strings (elastic#232)

add tests for double quotes and backslashes in string type values
w33ble · Nov 14, 2017 · 482a563 · 482a563
1 parent 858a1f3
commit 482a563
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 2 deletions.
diff --git a/common/lib/__tests__/ast.toExpression.js b/common/lib/__tests__/ast.toExpression.js
@@ -151,6 +151,42 @@ describe('ast toExpression', () => {
       expect(expression).to.equal('csv input="stuff\nthings"');
     });
 
+    it('single expression string value with a backslash', () => {
+      const astObj = {
+        type: 'expression',
+        chain: [{
+          type: 'function',
+          function: 'csv',
+          arguments: {
+            input: [
+              'slash \\\\ slash',
+            ],
+          },
+        }],
+      };
+
+      const expression = toExpression(astObj);
+      expect(expression).to.equal('csv input="slash \\\\ slash"');
+    });
+
+    it('single expression string value with a double quote', () => {
+      const astObj = {
+        type: 'expression',
+        chain: [{
+          type: 'function',
+          function: 'csv',
+          arguments: {
+            input: [
+              'stuff\nthings\n"such"',
+            ],
+          },
+        }],
+      };
+
+      const expression = toExpression(astObj);
+      expect(expression).to.equal('csv input="stuff\nthings\n\\"such\\""');
+    });
+
     it('single expression with number argument', () => {
       const astObj = {
         type: 'expression',

diff --git a/common/lib/ast.js b/common/lib/ast.js
@@ -3,13 +3,16 @@ import { getType } from '../lib/get_type';
 
 function getArgumentString(arg, argKey) {
   const type = getType(arg);
-  // TODO: MAJOR -- This breaks for single quoted strings that contain double quotes!
 
   function maybeArgKey(argString) {
     return (argKey == null || argKey === '_') ? argString : `${argKey}=${argString}`;
   }
 
-  if (type === 'string') return maybeArgKey(`"${arg}"`);
+  // TODO: this works, but seems a little hacky. it removes existing escaped chars on quotes
+  // and adds the escaping onto all other double quotes it finds in the string
+  const escapeQuotes = (val) => val.replace(/\\\"/g, '"').replace(/\"/g, '\\"');
+
+  if (type === 'string') return maybeArgKey(`"${escapeQuotes(arg)}"`);
   if (type === 'boolean' || type === 'null' || type === 'number') return maybeArgKey(`${arg}`);
   if (type === 'expression') return maybeArgKey(`{${getExpression(arg.chain)}}`);
   if (type === 'partial') return maybeArgKey('${' + getExpression(arg.chain) + '}');