Extend to paragraphs, based on v1.0.4 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repurposed for paragraphs
repurposed for paragraphs
added header, refactored code for transparency
updated header, comments, variables to reflect the new focus
fixed added tabs
updated readme according to the new purpose
I got stuck with the WP settings API, and the whole thing is behind the spec. So I’m throwing the code as-is and wait for the time to sit down and look how to properly extend it. Duplicate disambiguation would be needed too.
not functional!
Settings page display OK checkboxes functional Backend not working!
just for the record
for the record
account for using an older file for now
meanwhile reverted to paragraphs only
work is in progress, while 2 files are usable as provisionally intended
better regex (simpler is better)
account for better regex
recovered improved comments
add licence in file header
|
Sorry for the complications, but the correct view of the really proposed changes is now available at pewgeuges/add-anchor-links@version-1.0.4...pewgeuges:extend-to-paragraphs |
|
Actually found needless edits and reverted them, sorry for these. Also tried to minimize changes overall, shortening some of the added docblocks. |
WordPress uses p tags in blockquote elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Add Anchor Links functionality is optionally available for paragraphs, list items and block quotes, and it can be disabled for headings in case these get anchors from a TOC plugin and are made clickable.
This PR is based on v1.0.4. It replaces #2 as #2 is based on an older version and the fork was not rebased prior to preparing #2