-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uint256 improvements #797
Merged
jacqueswww
merged 11 commits into
vyperlang:master
from
jacqueswww:764_uint256_improvements
May 4, 2018
Merged
uint256 improvements #797
jacqueswww
merged 11 commits into
vyperlang:master
from
jacqueswww:764_uint256_improvements
May 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also allows `x += 1` to dynamically be allowed when int literally is a reasonable value. - Literal integers larger than 2 ^ 127 automatically are assumed to be uint256. - Literal integers larger than 2 ^ 256 will be prohibited.
fubuloubu
requested changes
Apr 30, 2018
vyper/utils.py
Outdated
@@ -90,6 +90,7 @@ class SizeLimits: | |||
MINNUM = -2**127 | |||
MAXDECIMAL = (2**127 - 1) * DECIMAL_DIVISOR | |||
MINDECIMAL = (-2**127) * DECIMAL_DIVISOR | |||
MAX_UINT256 = 2**256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max is 2**256-1
- Adds checks for assignment of uint256 literals.
jacqueswww
force-pushed
the
764_uint256_improvements
branch
from
May 1, 2018 11:33
ffb8d6e
to
69f2060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Implements #764. uint256 improvements.
- How I did it
- How to verify it
- Description for the changelog
- Cute Animal Picture