Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor[venom]: optimize lattice evaluation #4368

Merged
merged 10 commits into from
Nov 20, 2024
Merged

refactor[venom]: optimize lattice evaluation #4368

merged 10 commits into from
Nov 20, 2024

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Nov 20, 2024 •
edited by charles-cooper
Loading

What I did

Small optimization of the lattice evaluation method, along with some dead code removal.

How I did it

How to verify it

Commit message

this commit improves the `_eval()` method in the SCCP pass by trying
to return early when possible and avoid unnecessary set operations. it
also performs some minor code clean up and dead code removal.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal harkal changed the title feat[venom]: Optimization of lattice evaluation feat[venom]: optimization of lattice evaluation Nov 20, 2024
@harkal harkal marked this pull request as ready for review November 20, 2024 11:52
@charles-cooper charles-cooper changed the title feat[venom]: optimization of lattice evaluation refactor[venom]: optimize lattice evaluation Nov 20, 2024
charles-cooper
charles-cooper reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually made a couple small suggestions offline -- @harkal ping me again when you have considered them

charles-cooper
charles-cooper approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i think there might be other cases where we should actually be adding to ssa work items but maybe out of scope for this PR

@charles-cooper charles-cooper merged commit 0c23b21 into vyperlang:master Nov 20, 2024
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-cooper charles-cooper charles-cooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harkal @charles-cooper