External contract calls cannot be used internally #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
requested changes
Oct 8, 2017
| def bar() -> num: | ||
| return 1 | ||
|
|
||
| def _expr(x: address) -> num: |
There was a problem hiding this comment.
What's the difference between _stmt and _expr?
| """ | ||
| t.s = t.Chain() | ||
| c = get_contract(contract) | ||
| c._expr(t.a1) |
There was a problem hiding this comment.
This should fail because we passed an account address instead of a contract address IMO.
Maybe insert assert x.is_contract in the underlying module for using external contracts?
There was a problem hiding this comment.
I added in a codesize check to make sure it throws if the contract doesn't exist.
DavidKnott
force-pushed
the
improve-external-contract-calls
branch
from
a34de85 to
a27236f
Compare
This was referenced Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I added a check to external contract calls so that they can't be used internally.
- How I did it
I did this by checking that the
external_address != current_address.- How to verify it
Look at the test I wrote.
- Description for the changelog
None
- Cute Animal Picture