Fix repeated logging with topics #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacqueswww
suggested changes
Oct 6, 2017
| # # Check that casting matches manual conversion | ||
| # assert c._num256_to_num_call(2**127) == c.built_in_conversion(2**127) | ||
| # t.s = s | ||
| # # c._num256_to_num_call(-1) |
There was a problem hiding this comment.
@DavidKnott I think these slipped in from the other branch. Just replace with the ones we have in master now ;)
viper/parser.py
Outdated
| # Checks to see if there's any data | ||
| if not args: | ||
| return ['seq'], 0, 0 | ||
| holder = ['seq'] | ||
| maxlen = len(args) * 32 | ||
| for i, (arg, typ) in enumerate(zip(args, [arg.typ for arg in signature.args])): | ||
| # import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Remove pdb.trace() here.
DavidKnott
force-pushed
the
fix-logging
branch
4 times, most recently
from
b3cc97c
to
a628f6b
Compare
DavidKnott
force-pushed
the
fix-logging
branch
from
a628f6b
to
cb3ce65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Refactored the logging functionality and added support for logging the same event with topics multiple times. This PR is in response to #373
- How I did it
I cleaned up how event topics and data are parsed.
- How to verify it
Look at my pr, particularly the test I added:
test_logging_the_same_event_multiple_times_with_topics- Description for the changelog
None
- Cute Animal Picture