-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reimplement AST folding #3669
refactor: reimplement AST folding #3669
Conversation
…ctor/folding_alt2
""" | ||
y: constant(String[5]) = "szabo" | ||
x: constant(uint256) = as_wei_value(5, y) | ||
|
||
@external | ||
def foo(): | ||
a: uint256 = x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these tests should really go in tests/functional/builtins/folding/
FOO: constant(uint256) = 3 | ||
BAR: constant(uint256) = 5 | ||
BAZ: constant(uint256) = 19 | ||
BAX: constant(uint256) = uint256_addmod(FOO, BAR, BAZ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think typically in computer science lore the next name in the list is QUX
:D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but i like BAX too tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think typically in computer science lore the next name in the list is QUX :D
Oops I was not aware of this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work -- vyper is looking much cleaner now!
@cyberthirst please take a look and see if you think there are any regressions in this PR as it's a bit large! |
What I did
fixes #3363, #3344
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture