Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require loop variable annotation #3544

Closed
wants to merge 6 commits into from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Aug 2, 2023

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #3544 (36ef266) into master (cfda16c) will decrease coverage by 33.58%.
The diff coverage is 4.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #3544       +/-   ##
===========================================
- Coverage   89.11%   55.53%   -33.58%     
===========================================
  Files          85       85               
  Lines       11362    11373       +11     
  Branches     2584     2588        +4     
===========================================
- Hits        10125     6316     -3809     
- Misses        816     4527     +3711     
- Partials      421      530      +109     
Files Changed Coverage Δ
vyper/codegen/stmt.py 32.55% <0.00%> (-57.37%) ⬇️
vyper/semantics/analysis/local.py 33.24% <0.00%> (-58.38%) ⬇️
vyper/ast/pre_parser.py 38.83% <9.09%> (-45.95%) ⬇️

... and 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper
Copy link
Member

the issue with this is that it will conflict with iterator syntax if we ever support things like for x, y in zip(xs, ys): .... i think the thing to do here is maybe actually add more metadata in the pre_parser regarding the type annotation.

@tserg tserg closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants