Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate separate function names depending on context #3423

Merged
merged 4 commits into from
May 17, 2023

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 17, 2023

What I did

for backends which only have a single compilation context (i.e., they do not split initcode and runtime code like EVM), they need separate names for the two different codes generated per-function as of c202c4e. this is also hygienic - since the two functions actually have different codes as of c202c4e, give them different names.

How I did it

How to verify it

Commit message

for backends (like zksync) which only have a single compilation context
(i.e., they do not split initcode and runtime code like EVM), they need
separate names for the two different codes generated per-function as of
c202c4e3ec8. this is also hygienic - since the two functions actually
have different codes as of c202c4e3ec8, give them different names.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title chore: separate function names for internal functions depending on context chore: generate separate function names depending on context May 17, 2023
@charles-cooper charles-cooper marked this pull request as ready for review May 17, 2023 20:12
@charles-cooper charles-cooper requested a review from fubuloubu May 17, 2023 20:25
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #3423 (4e0602d) into master (3837ad3) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3423      +/-   ##
==========================================
+ Coverage   89.05%   89.17%   +0.12%     
==========================================
  Files          84       84              
  Lines       10760    10761       +1     
  Branches     2452     2451       -1     
==========================================
+ Hits         9582     9596      +14     
+ Misses        784      771      -13     
  Partials      394      394              
Impacted Files Coverage Δ
vyper/codegen/function_definitions/common.py 97.40% <100.00%> (ø)
.../codegen/function_definitions/internal_function.py 100.00% <100.00%> (ø)
vyper/codegen/self_call.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper changed the title chore: generate separate function names depending on context fix: generate separate function names depending on context May 17, 2023
@charles-cooper charles-cooper enabled auto-merge (squash) May 17, 2023 23:16
@charles-cooper charles-cooper merged commit 4f9f813 into vyperlang:master May 17, 2023
@charles-cooper charles-cooper deleted the chore/ctor_labels branch May 17, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants