Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve optimizer rules for comparison operators #3412

Merged

Conversation

charles-cooper
Copy link
Member

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #3412 (f28b1db) into master (7ac2d7c) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3412      +/-   ##
==========================================
- Coverage   89.05%   88.73%   -0.33%     
==========================================
  Files          86       86              
  Lines       10792    10800       +8     
  Branches     2449     2453       +4     
==========================================
- Hits         9611     9583      -28     
- Misses        781      816      +35     
- Partials      400      401       +1     
Impacted Files Coverage Δ
vyper/ir/optimizer.py 97.90% <100.00%> (-0.27%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper requested a review from fubuloubu May 16, 2023 18:34
@charles-cooper charles-cooper marked this pull request as ready for review May 16, 2023 18:34
@charles-cooper charles-cooper force-pushed the chore/add-optimizer-rules branch from 3329828 to 6773042 Compare May 16, 2023 18:48
@charles-cooper charles-cooper changed the title improve optimizer rules for ge, le, gt, lt chore: improve optimizer rules for comparison operators May 16, 2023
@charles-cooper charles-cooper enabled auto-merge (squash) May 16, 2023 19:37
@charles-cooper charles-cooper merged commit dcc230c into vyperlang:master May 16, 2023
@charles-cooper charles-cooper deleted the chore/add-optimizer-rules branch May 16, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants