fix: string to bool conversion #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3391 +/- ##
==========================================
- Coverage 88.92% 88.64% -0.28%
==========================================
Files 86 86
Lines 10726 10726
Branches 2440 2440
==========================================
- Hits 9538 9508 -30
- Misses 787 814 +27
- Partials 401 404 +3
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vyper/builtins/_convert.py
Outdated
| @@ -267,7 +267,7 @@ def _literal_decimal(expr, arg_typ, out_typ): | |||
| def to_bool(expr, arg, out_typ): | |||
| _check_bytes(expr, arg, out_typ, 32) # should we restrict to Bytes[1]? | |||
|
|
|||
| if isinstance(arg.typ, BytesT): | |||
| if isinstance(arg.typ, (BytesT, StringT)): | |||
There was a problem hiding this comment.
we probably want _BytestringT here
charles-cooper
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Conversion of string to bool should follow that of
BytesTto compare non-zero bytes, but it currently compares pointer instead.How I did it
Add
StringTto conditionHow to verify it
See tests
Commit message
Description for the changelog
Fix string to bool conversion
Cute Animal Picture