chore: remove dead code in IR generation #3389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3389 +/- ##
==========================================
- Coverage 88.92% 88.65% -0.28%
==========================================
Files 86 86
Lines 10726 10716 -10
Branches 2440 2436 -4
==========================================
- Hits 9538 9500 -38
- Misses 787 817 +30
+ Partials 401 399 -2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -28,13 +28,6 @@ def set_evm_verbose_logging(): | |||
| logger.setLevel("DEBUG2") | |||
|
|
|||
|
|
|||
| # Useful options to comment out whilst working: | |||
| # set_evm_verbose_logging() | |||
There was a problem hiding this comment.
let's keep this please, it ends up being useful from time to time :)
| func_ast, # vy_ast.FunctionDef | ||
| global_ctx, | ||
| interface_def=False, | ||
| constant_override=False, # CMC 20210907 what does this do? |
There was a problem hiding this comment.
let's try to do keep all refactoring of FunctionSignature in one place going forward, see #3390 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove dead code in IR generation
constant_overridekwarg inFunctionSignature.from_definitionof vyper/ast/signatures/function_signature.py is never set to True, and therefore theifbranch is never hit.parse_Nameinvyper/codegen/stmt.pyis never reachable because a statement can no longer be a standalone Name node. This was the original form of the equivalent function a while back. Also removed code related to a single statement Name node being "vdb", which "vdb" file no longer exists in the repo.How I did it
Delete code.
How to verify it
Nothing.
Commit message
Description for the changelog
Remove dead code in IR generation.
Cute Animal Picture