Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement libraries #2888

Closed

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 2, 2022

What I did

implement #2431

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #2888 (046ea16) into master (046ea16) will not change coverage.
The diff coverage is n/a.

❗ Current head 046ea16 differs from pull request most recent head c4da60b. Consider uploading reports for the commit c4da60b to get more accurate results

@@           Coverage Diff           @@
##           master    #2888   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          85       85           
  Lines       10756    10756           
  Branches     2286     2286           
=======================================
  Hits         9517     9517           
  Misses        789      789           
  Partials      450      450           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 2, 2022

This pull request introduces 2 alerts when merging bd9197d into 90e3d20 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 12, 2022

This pull request introduces 2 alerts when merging 9978390 into 6ea5174 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 6, 2022

This pull request introduces 2 alerts when merging 30efb9f into 573d77f - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 27, 2022

This pull request introduces 3 alerts when merging 4b8af48 into 046ea16 - view on LGTM.com

new alerts:

  • 3 for Wrong number of arguments in a class instantiation

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 27, 2022

This pull request introduces 3 alerts when merging c4da60b into 046ea16 - view on LGTM.com

new alerts:

  • 3 for Wrong number of arguments in a class instantiation

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants