Assert unreachable statement #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change assure to assert <expr>, UNREACHABLE.
|
Yassssss Ohhh, I can actually test this because I've been working on a tool |
|
Nope.... can't test this ugh. |
jacqueswww
commented
May 23, 2019
fubuloubu
approved these changes
May 23, 2019
|
Overall LGTM, mainly just wondering how the gas estimate was arrived at. |
Co-Authored-By: Charles Cooper <[email protected]>
|
Fixed the gas cost after calculating generated code by hand. |
|
@fubuloubu I tested above, and the exception info is empty, so message will do fine here. ipdb> print(e_info.value.__context__ )
None
ipdb>print(e_info.value.__cause__)
None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #711.
@charles-cooper @fubuloubu Time to lay this one to rest?
How I did it
How to verify it
Description for the changelog
Cute Animal Picture