Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string inside string, and special character highlighting #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

matthewtuby
Copy link

Please, check on a more complex/rich code, whether or not further syntax highlighting issues are present.

@fubuloubu
Copy link
Member

Hey @matthewtuby! Thank you for contributing this!

However, I can't seem to notice a difference when trying this with this contract:
https://github.com/iearn-finance/yearn-vaults/blob/7df3e77d6ae52f098e80f0fbc424f96473a2790c/contracts/Vault.vy#L2-L36

Do you have an example of what this looks like in practice? It actually seems like that comment could be a misnomer, as I have quotes in a docstring working just fine there

@matthewtuby
Copy link
Author

Right one is the original, left one after adding the changes.
Nice to see that this breaks at certain cases like block comments, wouldn't found those without you pointing it out.
image
Will try to fix it

@fubuloubu
Copy link
Member

Nice! No idea how to test this stuff lol

@fubuloubu
Copy link
Member

@matthewtuby is this okay to merge? no idea why I didn't merge yet lol

@matthewtuby
Copy link
Author

Haven't managed to resolve the issue shown in the image above.
At this point, I gave up on the cause.
Can be merged, although it's not a solution but a tradeoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants