Use correct source code when error happens in library #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/unitary/test_modules.py
Outdated
| @@ -9,3 +9,5 @@ def test_throw(): | |||
| c = boa.load(FIXTURES / "module_contract.vy") | |||
| with boa.reverts("Error with message"): | |||
| c.fail() | |||
| with boa.reverts("error message for devs"): | |||
There was a problem hiding this comment.
if we are going to use the same line for both errors, we should probably use the kwarg for reverts() so it's clear what we are testing for
charles-cooper
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The incorrect source code was being sent to
DevReason.at_source_location.As a result, when the error happened in a library, the contract source code was being parsed, not the library code.
Generally, this meant that dev reasons were not working properly. However, if the contract happened to have invalid code at that line, boa would crash parsing that line. In the case encountered below, the contract line had a multiline string
"""in this line, which by itself isn't valid code.How I did it
By using the ast source code, not the contract source code, when trying to get the dev reason.
How to verify it
Cute Animal Picture