added nicknames to envs #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boa/environment.py
Outdated
| self.evm = PyEVM(self, fast_mode_enabled, fork_try_prefetch_state) | ||
|
|
||
| def set_random_seed(self, seed=None): | ||
| self._random = random.Random(seed) | ||
|
|
||
| def set_nickname(self, nickname): |
There was a problem hiding this comment.
when would set_nickname be called?
There was a problem hiding this comment.
Maybe you have 2 ZKSync branches and you want to call one zksync-testnet and one zksync-mainnet
There was a problem hiding this comment.
yea but it is already set at construction, so i'm not sure why set_nickname would be called after construction
There was a problem hiding this comment.
If you’re in a Python shell and you setup zksync and called it zksync, but then realized you have 2 zksync chains, you’d have to just make two new ones with new names? Feels awkward to then have 3.
- zksync
- Zksync testnet
- Zksync mainnet
This was referenced Aug 29, 2024
Leminkay
pushed a commit
to Leminkay/titanoboa
that referenced
this pull request
Oct 28, 2024
I added the nickname attribute to the Env and NetworkEnv objects. * added nicknames to envs * fix url masking --------- Co-authored-by: Charles Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
nicknameattribute to theEnvandNetworkEnvobjects.pyproject.tomlto havedev-dependencies, so all dependencies can be in a single file, instead of split.If the dev-dependencies change is nice, I'm happy to update
CONTRIBUTING.mddocumentation as such, and also the rest of the dependency management.How I did it
How to verify it
Description for the changelog
nicknameattribute toEnvandNetworkEnvclassesCute Animal Picture