Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle constructor stack trace (vyper 0.4) #234

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented May 21, 2024

This PR is similar to #228 however it targets the 0.4.0 branch. Vyper >=0.4.0-rc4 also has source maps for constructors (since vyperlang/vyper#4008).

What I did

  • Fix and test exceptions during contract construction

How I did it

  • Use 'assembly' instead of 'assembly_runtime' source map during the constructor
  • Add tests

How to verify it

  • Tests are included

Description for the changelog

  • reverts in constructors have proper stack traces

Cute Animal Picture

image

@DanielSchiavini DanielSchiavini changed the title Fix/get logs constructor 0.4.0 feat: handle constructor stack trace (vyper 0.4) May 21, 2024
@DanielSchiavini DanielSchiavini marked this pull request as ready for review May 27, 2024 09:47
Co-authored-by: Charles Cooper <[email protected]>
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. thanks!

@charles-cooper charles-cooper merged commit 7576f71 into vyperlang:vyper-0.4.0 May 31, 2024
9 checks passed
@DanielSchiavini DanielSchiavini deleted the fix/get-logs-constructor-0.4.0 branch October 9, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants