fix: Notify user of tx fail in boa call output #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boa/network.py
Outdated
| @@ -419,6 +419,8 @@ def _send_txn(self, from_, to=None, gas=None, value=None, data=None): | |||
| print(f"tx broadcasted: {tx_hash}") | |||
|
|
|||
| receipt = self._rpc.wait_for_tx_receipt(tx_hash, self.tx_settings.poll_timeout) | |||
| if receipt["status"] != "0x1": | |||
| raise RuntimeError(f"txn failed: {receipt}") | |||
There was a problem hiding this comment.
BoaError expects a stack trace. Which should we use?
There was a problem hiding this comment.
RuntimeError might be ok, but i'm not sure. i think the only way we can reach here is if the fork mode simulation did not raise any errors, but there is an error when actually sending the transaction (presumably caused by a state change between our snapshot and now).
There was a problem hiding this comment.
This was the example in the issue https://bscscan.com/tx/0x77967045c0b62986ad3cf8933c746dff0b448dbffb2e71b89869e64ff54d1012
|
@charles-cooper closed #138 as completed in e3c4e9c 2 weeks ago |
|
it was actually reverted in the same PR - aca2926 |
charles-cooper
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138
What I did
How I did it
How to verify it
Description for the changelog
Cute Animal Picture