Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep abi in ABIContract #172

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Keep abi in ABIContract #172

merged 4 commits into from
Feb 28, 2024

Conversation

DanielSchiavini
Copy link
Collaborator

What I did

  • Added _abi field to ABIContract, so it can be available for later use, e.g. when using fetch_from_etherscan

How I did it

  • Moving the function creation to the ABIContract

How to verify it

  • The ABI is still available after the contract is created

Description for the changelog

N/A

Cute Animal Picture

image

@charles-cooper
Copy link
Member

should we expose abi on vyper contracts too?

@charles-cooper charles-cooper merged commit 01e5c81 into vyperlang:master Feb 28, 2024
7 of 9 checks passed
@DanielSchiavini DanielSchiavini deleted the abi-parsing branch February 28, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-cooper charles-cooper charles-cooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSchiavini @charles-cooper