Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add mypy to pre-commit #146

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Conversation

DanielSchiavini
Copy link
Collaborator

What I did

Closes #144

How I did it

  • Add mypy to pre-commit
  • Fix the issues reported

How to verify it

  • Pre-commit should pass
  • Logic should not be changed

Description for the changelog

  • Add better support for mypy

Cute Animal Picture

image

@DanielSchiavini DanielSchiavini changed the title Add mypy to pre-commit chore: Add mypy to pre-commit Feb 13, 2024
boa/vm/fork.py Outdated
@@ -1,5 +1,5 @@
import os
from typing import Any
from typing import Any, Dict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need the Dict import

@charles-cooper charles-cooper merged commit 786e44f into vyperlang:master Feb 14, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add types for better integrating with mypy and other checkers
2 participants