Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch encoder/decoder to convert ABI addresses #133

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

DanielSchiavini
Copy link
Collaborator

Closes #127

What I did

Got rid of boa.contracts.utils and applied the address conversion to all abi operations.

How I did it

  • Add a new test to make sure the previous implementation did not work recursively
  • Inherit eth.codecs.abi classes to convert addresses
  • Create an AddressWrapper that works with vyper_object

How to verify it

  • Existing tests should not be broken
  • Test is updated to reproduce previous issue

Description for the changelog

  • Address strings are always converted to objects when using the ABI

Cute Animal Picture

image

boa/util/abi.py Outdated Show resolved Hide resolved
boa/util/abi.py Outdated Show resolved Hide resolved
boa/util/abi.py Outdated Show resolved Hide resolved
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@charles-cooper charles-cooper merged commit b0ac8cb into vyperlang:master Feb 7, 2024
5 of 7 checks passed
@DanielSchiavini DanielSchiavini deleted the 127/patch-address branch February 19, 2024 13:46
@DanielSchiavini DanielSchiavini self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch encoder/decoder to convert ABI addresses
2 participants