fix debug frames for uninitialized variables #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSchiavini
force-pushed
the
debug-frames
branch
from
f33d3c9
to
559e371
Compare
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I experienced issues when boa tried to print debug frames before a specific dyn array is initialized.
The memory might contain a very large length, which causes boa to loop forever.
How I did it
I created a minimal reproduction in unit test and fixed it by handling unexpected array lengths.
How to verify it
Tests included
Description for the changelog
Fix endless loops when debugging uninitialized variables
Cute Animal Picture