Merge pull request #235 from charles-cooper/fix/disk-cache-race

fix race in disk cache
vyperlang · May 28, 2024 · 0625410 · 0625410
2 parents 7b4854d + 108181d
commit 0625410
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/boa/util/disk_cache.py b/boa/util/disk_cache.py
@@ -66,8 +66,9 @@ def caching_lookup(self, string, func):
                 return pickle.loads(f.read())
         except OSError:
             res = func()
-            tid = threading.get_ident()
-            tmp_p = p.with_suffix(f".{tid}.unfinished")
+            # use process ID and thread ID to avoid race conditions
+            job_id = f"{os.getpid()}.{threading.get_ident()}"
+            tmp_p = p.with_suffix(f".{job_id}.unfinished")
             with tmp_p.open("wb") as f:
                 f.write(pickle.dumps(res))
             # rename is atomic, don't really need to care about fsync