Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce scope to linter #38

Closed
vweevers opened this issue Aug 30, 2019 · 3 comments
Closed

Reduce scope to linter #38

vweevers opened this issue Aug 30, 2019 · 3 comments
Labels
semver-major Changes that break backward compatibility

Comments

@vweevers
Copy link
Owner

By removing "generative" plugins like remark-git-contributors and remark-toc (#36), which are too opinionated. Instead add a plugins options so dependents can load these themselves.
@vweevers vweevers added the semver-major Changes that break backward compatibility label Aug 30, 2019
@vweevers vweevers mentioned this issue Sep 18, 2021
Closed
9 tasks
vweevers added a commit that referenced this issue Nov 12, 2021
@vweevers
Breaking: remove remark-git-contributors plugin
c43ceea 
If you had a CONTRIBUTORS.md it will no longer be updated.

Ref #38
@vweevers
Copy link
Owner Author

Keeping remark-toc for now.

vweevers added a commit that referenced this issue Nov 14, 2021
@vweevers
Breaking: remove remark-git-contributors plugin
e8ec0c8 
If you had a CONTRIBUTORS.md it will no longer be updated.

Ref #38
@vweevers
Copy link
Owner Author

GitHub's new code view, which makes the outline of markdown documents more accessible, further increases the reduncancy of hallmark's ToC:

image

vweevers added a commit that referenced this issue Apr 6, 2024
@vweevers
Breaking: remove remark-toc plugin
4d9c10a 
If you have a "Table of Contents" section in your README, it will
no longer be automatically updated. Either remove it, or add the
plugin to hallmark configuration.

Ref: #38
Closes: #36
Category: removal
@vweevers vweevers mentioned this issue Apr 6, 2024
Merged
vweevers added a commit that referenced this issue Apr 6, 2024
@vweevers
Breaking: remove remark-toc plugin (#118)
19f4a8f 
If you have a "Table of Contents" section in your README, it will
no longer be automatically updated. Either remove it, or add the
plugin to hallmark configuration.

Ref: #38
Closes: #36
Category: removal
@vweevers
Copy link
Owner Author

vweevers commented Apr 6, 2024

remark-git-contributors and remark-toc are gone. TBD what the next step is. I do want to decouple the changelog generator if possible (or even make that the only purpose of hallmark) but that can wait. Closing this for now.

@vweevers vweevers closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major Changes that break backward compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vweevers