Make the result stream of Images::build continuous
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marhkb
force-pushed
the
refactor/make-images-pull-continuous
branch
from
7d0b226
to
da0e9eb
Compare
Currently, when the `Images::build` endpoint is called, no continuous stream is returned: once an image is successfully built, a single `ImageBuildLibpod200Response` is returned with the entire output of the build process. This is especially bad for user interfaces, as no feedback can be provided to the user. To make the stream continuous, the implementation of the endpoint is rewritten. Here, the implementation of the endpoint `Images::pull` is used as a template.
marhkb
force-pushed
the
refactor/make-images-pull-continuous
branch
from
da0e9eb
to
daba393
Compare
|
Awesome work, thanks for handling this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Currently, when the
Images::buildendpoint is called, no continuousstream is returned: once an image is successfully built, a single
ImageBuildLibpod200Responseis returned with the entire output of thebuild process.
This is especially bad for user interfaces, as no feedback can be
provided to the user.
To make the stream continuous, the implementation of the endpoint is
rewritten. Here, the implementation of the endpoint
Images::pullisused as a template.
How did you verify your change:
I tested it locally: no stream item was returned before building was completed.
What (if anything) would need to be called out in the CHANGELOG for the next release:
(BREAKING) Make the result stream of
Images::buildcontinuous