Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing attributes for create container request added #127

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

Babidiii
Copy link
Contributor

What did you implement:

The following missing attributes were added to CreateContainerOpts :

  • device_cgroup_rule
  • devices
  • host_device_list
  • image_volumes
  • networks
  • overlay_volumes
  • r_limits
  • secrets
  • throttle_read_bps_device
  • throttle_read_iops_device
  • throttle_write_bps_device
  • throttle_write_iops_device
  • volumes

Closes: #126

How did you verify your change:

By creating containers from code with the missing attributes.

What (if anything) would need to be called out in the CHANGELOG for the next release:

Missing attributes for container creation added.

@vv9k vv9k merged commit 1ff8aae into vv9k:master Jul 28, 2022
@vv9k
Copy link
Owner

vv9k commented Jul 28, 2022

Looks good, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing attributes for container creation request
2 participants