Add portmappings
to ContainerCreateOptsBuilder
#117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
While working on this PR I saw that there is a TODO for
portmappings
inContainerCreateOptsBuilder
, which I need. Thus, I implemented it.How did you verify your change
I tested this within the PR.
The code I use is basically:
The portmappings are accepted and are shown in cockpit.
What (if anything) would need to be called out in the CHANGELOG for the next release
Probably the titles of both commits would fit here.