Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent sidebar from jumping when in START or UNFIXED state #14

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

vursen
Copy link
Owner

@vursen vursen commented Nov 28, 2021

The PR is aimed to prevent the sidebar from jumping which sometimes happens in the START and UNFIXED states as reported in #11.

Fixes #11

@vursen vursen force-pushed the fix/start-to-finish branch from 9e45842 to 75a88d7 Compare November 28, 2021 09:39
@vursen vursen changed the title fix: fix START => FINISH transition for sidebar not exceeding viewport fix: prevent jumping of sidebar when not exceeding viewport and in the START state Nov 28, 2021
@vursen vursen changed the title fix: prevent jumping of sidebar when not exceeding viewport and in the START state fix: prevent jumping when sidebar does not exceed viewport and in START state Nov 28, 2021
@vursen vursen force-pushed the fix/start-to-finish branch from 75a88d7 to 8b6eec0 Compare November 28, 2021 09:42
@vursen vursen changed the title fix: prevent jumping when sidebar does not exceed viewport and in START state fix: fix START => FINISH transition for sidebar not exceeding viewport Nov 28, 2021
@vursen vursen force-pushed the fix/start-to-finish branch from 8b6eec0 to d953c24 Compare November 28, 2021 18:36
@vursen vursen force-pushed the fix/start-to-finish branch from d953c24 to 71a3b8e Compare November 28, 2021 18:41
@vursen vursen changed the title fix: fix START => FINISH transition for sidebar not exceeding viewport fix: prevent sidebar from jumping in START and UNFIXED states Nov 28, 2021
@vursen vursen changed the title fix: prevent sidebar from jumping in START and UNFIXED states fix: prevent sidebar from jumping when in START or UNFIXED state Nov 28, 2021
@vursen vursen merged commit 2f73fc8 into master Nov 28, 2021
@vursen vursen deleted the fix/start-to-finish branch November 29, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With very tall page and sidebar there is just a jump at halfway
1 participant