Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Marketplace App Variables #389

Merged

Conversation

christhemorse
Copy link
Contributor

Description

This PR updates Vultr-CLI to support user-supplied variables for Vultr Marketplace apps. First is the marketplace/app commands in order to facilitate a public/no-auth list variables endpoint. This updates also contains a new flag for including app variables on create for VPS instances and bare metal servers.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the enhancement New feature or request label Dec 18, 2023
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v2	[no test files]

Pusher: @christhemorse, Action: pull_request_target

Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v2	[no test files]

Pusher: @christhemorse, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@optik-aper optik-aper merged commit 96e97ab into vultr:master Dec 18, 2023
2 checks passed
@christhemorse christhemorse deleted the support-marketplace-app-variables branch December 19, 2023 13:34
@optik-aper optik-aper mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants