Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dkls/schnorr keysign #1560

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add dkls/schnorr keysign #1560

merged 1 commit into from
Jan 9, 2025

Conversation

@yvebe yvebe self-assigned this Jan 9, 2025
}
val receiverString = String(receiverArray, Charsets.UTF_8)
println("sending message from $localPartyID to: $receiverString, content length: ${encodedOutboundMessage.length}")
messenger?.send(localPartyID, receiverString, encodedOutboundMessage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
messenger?.send(localPartyID, receiverString, encodedOutboundMessage)
messenger.send(localPartyID, receiverString, encodedOutboundMessage)

delay(100)
}
} catch (e: Exception) {
Timber.e("Failed to get messages", e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Timber.e("Failed to get messages", e)
Timber.e(e,"Failed to get messages")


val elapsedTime = (System.nanoTime() - start) / 1_000_000_000.0
if (elapsedTime > 60) {
error("timeout: failed to create vault within 60 seconds")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error("timeout: failed to create vault within 60 seconds")
error("timeout: failed to keysign within 60 seconds")

Copy link
Contributor

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyluo johnnyluo merged commit b13473d into main Jan 9, 2025
1 check passed
@johnnyluo johnnyluo deleted the feature/dkls-keysign branch January 9, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADD: Implement DKLS keygen / Keysign
2 participants