Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs and set sdk target to 35 #1481

Merged

Conversation

yevhen1sec
Copy link
Collaborator

Fixes #1472

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@yevhen1sec yevhen1sec requested a review from yvebe December 12, 2024 08:32
Comment on lines 85 to 86
Surface(
color = Colors.Default.oxfordBlue800,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just set background color for box?

Comment on lines 63 to 70
statusBarStyle = SystemBarStyle.auto(
Colors.Default.oxfordBlue800.toArgb(),
Colors.Default.oxfordBlue800.toArgb(),
) { true },
navigationBarStyle = SystemBarStyle.auto(
Colors.Default.oxfordBlue800.toArgb(),
Colors.Default.oxfordBlue800.toArgb(),
) { true },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make one variable for both SystemBarStyle and reuse it in both

@yevhen1sec yevhen1sec requested a review from yvebe December 12, 2024 11:57
@yvebe yvebe merged commit d07cd0c into main Dec 12, 2024
1 check passed
@yvebe yvebe deleted the improvement/remove-deprecated-apis-and-set-sdk-target-to-35 branch December 12, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated APIs
2 participants