Add Lifi price provider #1453
Merged
Add Lifi price provider #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyluo
reviewed
Dec 5, 2024
| contractAddress | ||
| ) | ||
| } | ||
| }.awaitAll().associate { (contractAddress, priceInUsd) -> |
There was a problem hiding this comment.
is it because that lifi only have USD price , thus we use USDT to convert it to local currency?
maybe leave a comment here , so it will be easier for people to understand it in the future
There was a problem hiding this comment.
is it because that lifi only have USD price , thus we use USDT to convert it to local currency? maybe leave a comment here , so it will be easier for people to understand it in the future
Exactly
Added comment to make it more clear
aminsato
commented
Dec 10, 2024
Comment on lines
220
to
221
| //Since Lifi provides prices in USD, we use USDT to convert them into the local currency | ||
| contractAddress to mapOf(currency to priceInUsd * tetherPrice) |
yvebe
requested changes
Dec 11, 2024
| @Serializable | ||
| internal data class LiQuestResponseJson( | ||
| @SerialName("priceUSD") | ||
| val priceUSD: String, |
There was a problem hiding this comment.
Suggested change
| val priceUSD: String, | |
| val priceUsd: String, |
| ) | ||
| } catch (e: Exception) { | ||
| BigDecimal.ZERO |
There was a problem hiding this comment.
let's do null here, and decide if we want zero in other places
yvebe
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1136
Lifi returns prices in USD, but we have enhanced it to support conversion into other currencies as well