Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use HttpStatusCode.fromValue for status description #1402

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Nov 24, 2024

The response.status.description does not provide a desription for failed failed responses. Therefore HttpStatusCode is used as an alternative.

https://discord.com/channels/1203844257220395078/1244701510873387149/1310113422913830942

Before
Swap_before

After

Swap_error

@aminsato aminsato requested review from yvebe and johnnyluo November 24, 2024 06:13
@yvebe yvebe merged commit 1179676 into main Nov 25, 2024
1 check passed
@yvebe yvebe deleted the fix/use-httpstatuscode branch November 25, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants