Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling for 1Inch swap quote responses #1366

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fix error handling for 1Inch swap quote responses #1366

merged 4 commits into from
Nov 21, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Nov 15, 2024 •
edited
Loading

@aminsato aminsato force-pushed the fix/1inch_swap_quote branch from 7f4e5e4 to 65933df Compare November 15, 2024 17:31
@aminsato aminsato marked this pull request as draft November 15, 2024 17:32
@aminsato aminsato force-pushed the fix/1inch_swap_quote branch from 65933df to 0baf6d4 Compare November 16, 2024 10:58
@aminsato aminsato marked this pull request as ready for review November 16, 2024 10:59
@aminsato aminsato requested a review from yvebe November 18, 2024 15:33
@aminsato aminsato force-pushed the fix/1inch_swap_quote branch 4 times, most recently from 8827331 to fdb9f8c Compare November 19, 2024 09:03
@aminsato aminsato force-pushed the fix/1inch_swap_quote branch from fdb9f8c to 4f5b1ef Compare November 19, 2024 09:06
@yvebe yvebe merged commit ad42b62 into main Nov 21, 2024
1 check passed
@yvebe yvebe deleted the fix/1inch_swap_quote branch November 21, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvebe yvebe yvebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminsato @yvebe