Fix error handling for LiFi swap quote responses #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminsato
changed the title
yvebe
requested changes
Nov 13, 2024
| @@ -104,6 +107,31 @@ class THORChainSwapQuoteResponseJsonSerializer @Inject constructor(private val j | |||
| } | |||
| } | |||
|
|
|||
| @Singleton | |||
There was a problem hiding this comment.
please don't use singleton annotation directly on classes, provide that info in the module where they're binded/provided
yvebe
requested changes
Nov 15, 2024
Comment on lines
43
to
46
| @Binds | ||
| fun bindLiFiSwapQuoteResponseSerializer( | ||
| impl: LiFiSwapQuoteResponseSerializerImpl, | ||
| ): LiFiSwapQuoteResponseSerializer |
There was a problem hiding this comment.
Suggested change
| @Binds | |
| fun bindLiFiSwapQuoteResponseSerializer( | |
| impl: LiFiSwapQuoteResponseSerializerImpl, | |
| ): LiFiSwapQuoteResponseSerializer | |
| @Binds | |
| @Singleton | |
| fun bindLiFiSwapQuoteResponseSerializer( | |
| impl: LiFiSwapQuoteResponseSerializerImpl, | |
| ): LiFiSwapQuoteResponseSerializer |
yvebe
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1273