Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading indicator on the Keysign Discovery #1326

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add loading indicator on the Keysign Discovery #1326

merged 2 commits into from
Nov 18, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Nov 9, 2024

No description provided.

@aminsato aminsato requested a review from yvebe November 9, 2024 10:15
yvebe
yvebe requested changes Nov 11, 2024
View reviewed changes
app/src/main/java/com/vultisig/wallet/ui/models/keysign/KeysignFlowViewModel.kt Outdated
Comment on lines 580 to 582
isLoading.value = true
_participantDiscovery?.stop()
isLoading.value = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aminsato aminsato requested a review from yvebe November 12, 2024 08:38
@yvebe yvebe merged commit 8708652 into main Nov 18, 2024
1 check passed
@yvebe yvebe deleted the add/loading-indicator-keysign branch November 18, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvebe yvebe yvebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminsato @yvebe