Fix multiple click #1312
Fix multiple click #1312
Conversation
aminsato
force-pushed
the
fix/multiple-click
branch
from
d726ab0 to
d1a3a9d
Compare
| @@ -514,10 +516,26 @@ internal class SendFormViewModel @Inject constructor( | |||
| ) | |||
| } catch (e: InvalidTransactionDataException) { | |||
| showError(e.text) | |||
| } finally { | |||
| disableSendingForm() | |||
There was a problem hiding this comment.
are you sure that we should disable it here? what if this ends with error? looks like it will disable sending forever
There was a problem hiding this comment.
What I mean by disableSendingForm is that in this state, the form is not in the sending state. The finally section is always executed, even if an exception occurs. As a result, whether the operation completes successfully or an exception occurs, the form will be out of submission mode, and the user can submit it again.
There was a problem hiding this comment.
that's probably not the best naming then :) let's maybe call it showLoading and hideLoading for simplicity?
| @@ -514,10 +516,26 @@ internal class SendFormViewModel @Inject constructor( | |||
| ) | |||
| } catch (e: InvalidTransactionDataException) { | |||
| showError(e.text) | |||
| } finally { | |||
| disableSendingForm() | |||
There was a problem hiding this comment.
that's probably not the best naming then :) let's maybe call it showLoading and hideLoading for simplicity?
| when (isBusy) { | ||
| true -> UiCirclesLoader( | ||
| color1 = textColor ?: appColor.oxfordBlue800 | ||
| ) | ||
|
|
||
| false -> content?.invoke() ?: Text( | ||
| text = text, | ||
| color = if (disabled == true) appColor.neutral800 else textColor | ||
| ?: appColor.oxfordBlue800, | ||
| style = textStyle ?: Theme.montserrat.subtitle1 | ||
| ) | ||
| } |
There was a problem hiding this comment.
there's no need for when if conditions are true & false, just use if-else statement
| @@ -28,7 +29,8 @@ internal fun MultiColorButton( | |||
| trailingIcon: Int? = null, | |||
| iconColor: Color? = null, | |||
| backgroundColor: Color? = null, | |||
| disabled: Boolean? = false, | |||
| isBusy: Boolean = false, | |||
There was a problem hiding this comment.
| isBusy: Boolean = false, | |
| isLoading: Boolean = false, |
…screen Added `launchSingleTop=true` to prevent multiple instances of the same screen from being opened. This change ensures that navigating to a destination that is already on top of the back stack will not create a new instance of that destination, thus preventing duplicate screens.
Fixes #1178