Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1289

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Update dependencies #1289

merged 2 commits into from
Nov 4, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Nov 3, 2024

No description provided.

@aminsato aminsato force-pushed the update/Dependencies branch 2 times, most recently from 05ac854 to 5293676 Compare November 3, 2024 10:56
@aminsato aminsato force-pushed the update/Dependencies branch from 5293676 to 233e4d6 Compare November 3, 2024 11:55
@aminsato aminsato requested a review from yvebe November 3, 2024 11:57
@@ -29,7 +29,7 @@ internal fun uriToBitmap(contentResolver: ContentResolver, selectedFileUri: Uri)

internal fun Bitmap.addWhiteBorder(borderSize: Float): Bitmap {
val bmpWithBorder =
Bitmap.createBitmap(width + (borderSize * 2).toInt(), height + (borderSize * 2).toInt(), config)
Bitmap.createBitmap(width + (borderSize * 2).toInt(), height + (borderSize * 2).toInt(), config?: Bitmap.Config.RGB_565)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not argb_8888?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aminsato aminsato requested a review from yvebe November 4, 2024 11:50
@yvebe yvebe merged commit c739c0c into main Nov 4, 2024
1 check passed
@yvebe yvebe deleted the update/Dependencies branch November 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants