Add monthly backup reminder #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvebe
requested changes
Nov 12, 2024
| navigator.navigate(Destination.BackupPassword(vaultId!!)) | ||
| } | ||
| } | ||
|
|
||
| fun dismissBackupReminder() = viewModelScope.launch { | ||
| uiState.update { it.copy(showMonthlyBackupReminder = false) } |
There was a problem hiding this comment.
update is not a suspend method, so it doesn't need to be inside of launch
| @@ -201,8 +216,17 @@ internal class VaultAccountsViewModel @Inject constructor( | |||
| @Suppress("ReplaceNotNullAssertionWithElvisReturn") | |||
| fun backupVault() { | |||
| viewModelScope.launch { | |||
| uiState.update { it.copy(showMonthlyBackupReminder = false) } | |||
There was a problem hiding this comment.
i suggest reusing dismissBackupReminder() method for all of the code which hides reminder (after launch will be removed from dismiss)
| @@ -61,6 +64,8 @@ internal class VaultAccountsViewModel @Inject constructor( | |||
| private val vaultDataStoreRepository: VaultDataStoreRepository, | |||
| private val accountsRepository: AccountsRepository, | |||
| private val balanceVisibilityRepository: BalanceVisibilityRepository, | |||
| private val getGlobalBackupReminderStatus: GetGlobalBackupReminderStatus, | |||
| private val neverShowGlobalBackupReminder: NeverShowGlobalBackupReminder, | |||
There was a problem hiding this comment.
Suggested change
| private val neverShowGlobalBackupReminder: NeverShowGlobalBackupReminder, | |
| private val setNeverShowGlobalBackupReminder: NeverShowGlobalBackupReminder, |
actions require imperative names
| onDismiss: () -> Unit, | ||
| onBackup: () -> Unit, | ||
| onDoNotRemind: () -> Unit, | ||
| ){ |
|
|
||
| object VultiDate { | ||
| fun getEpochMonth(): Int { | ||
| val localDate = java.time.LocalDate.now() |
| object VultiDate { | ||
| fun getEpochMonth(): Int { | ||
| val localDate = java.time.LocalDate.now() | ||
| return localDate.minusYears(1970).year * 12 + localDate.monthValue |
There was a problem hiding this comment.
this is rather weird, look into kotlinx.datetime
| import kotlinx.coroutines.flow.first | ||
| import javax.inject.Inject | ||
|
|
||
| interface GetGlobalBackupReminderStatus : suspend () -> Boolean |
There was a problem hiding this comment.
status, which is boolean, is not really informative about what that status means. if you use boolean as return, prefer to name a check somehow e.g. IsGlobalBackupReminderRequired (UseCase)
also, do not forget to postfix that with UseCase
Comment on lines
16
to
32
| when (shownMonth) { | ||
| 0 -> { | ||
| vaultDataStoreRepository.setGlobalBackupReminderStatus(currentEpochMonth) | ||
| return true | ||
| } | ||
| -1 -> { | ||
| return false | ||
| } | ||
| currentEpochMonth -> { | ||
| vaultDataStoreRepository.setGlobalBackupReminderStatus(currentEpochMonth) | ||
| return false | ||
| } | ||
| else -> { | ||
| vaultDataStoreRepository.setGlobalBackupReminderStatus(currentEpochMonth) | ||
| return true | ||
| } | ||
| } |
There was a problem hiding this comment.
i actually do not understand what happens here
There was a problem hiding this comment.
Here logic that do 2 things
- depends on record in ds should we show reminder
- rewrite ds if needed
| interface NeverShowGlobalBackupReminder : suspend () -> Unit | ||
|
|
||
| internal class NeverShowGlobalBackupReminderImpl @Inject constructor( | ||
| val vaultDataStoreRepository: VaultDataStoreRepository, |
There was a problem hiding this comment.
Suggested change
| val vaultDataStoreRepository: VaultDataStoreRepository, | |
| private val vaultDataStoreRepository: VaultDataStoreRepository, |
| val vaultDataStoreRepository: VaultDataStoreRepository, | ||
| ) : NeverShowGlobalBackupReminder { | ||
| override suspend fun invoke() { | ||
| vaultDataStoreRepository.setGlobalBackupReminderStatus(-1) |
yvebe
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266