Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch THORChain network id on startup #1279

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fetch THORChain network id on startup #1279

merged 1 commit into from
Oct 31, 2024

Conversation

yvebe
Copy link
Collaborator

@yvebe yvebe commented Oct 31, 2024

Fix #909

@yvebe yvebe added this to the Release 1.0.31 milestone Oct 31, 2024
@yvebe yvebe self-assigned this Oct 31, 2024
johnnyluo
johnnyluo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyluo johnnyluo merged commit e1b2b06 into main Oct 31, 2024
1 check passed
@yvebe yvebe deleted the feature/fetch-thorchain-network-id branch November 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyluo johnnyluo johnnyluo approved these changes

Assignees

@yvebe yvebe

Labels
None yet
Projects
None yet
Milestone
Release 1.0.33
Development

Successfully merging this pull request may close these issues.

BUG: THORChain fetch chain id using api
2 participants
@yvebe @johnnyluo