Add custom token to Solana #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminsato
requested review from
yevhen1sec,
yvebe and
johnnyluo
and removed request for
yevhen1sec
yvebe
requested changes
Oct 29, 2024
| @@ -50,6 +53,7 @@ internal data class ChainTokensUiModel( | |||
| val canSelectTokens: Boolean = false, | |||
| val isBalanceVisible: Boolean = true, | |||
| val isBuyWeweVisible: Boolean = false, | |||
| val enableCustomToken: Boolean = false, | |||
There was a problem hiding this comment.
why would you add a new parameter and a view for that? we have canSelectTokens field
| val uiState = MutableStateFlow(ChainTokensUiModel()) | ||
| val uiState = MutableStateFlow( | ||
| ChainTokensUiModel( | ||
| enableCustomToken = Chain.fromRaw(chainRaw) == Chain.Solana |
There was a problem hiding this comment.
same here, there's already a mechanism for that
Comment on lines
167
to
177
| fun openCustomTokenScreen() { | ||
| viewModelScope.launch { | ||
| navigator.navigate( | ||
| Destination.CustomToken( | ||
| chainId = chainRaw | ||
| ) | ||
| ) | ||
| val searchedCoin = requestResultRepository.request<Coin>(REQUEST_SEARCHED_TOKEN_ID) | ||
| vaultRepository.addTokenToVault(vaultId, searchedCoin) | ||
| } | ||
| } |
There was a problem hiding this comment.
same here, all of this is already done by our old custom tokens screen
| @@ -89,6 +89,7 @@ internal class CoinGeckoApiImpl @Inject constructor( | |||
| Chain.Optimism -> "optimistic-ethereum" | |||
| Chain.BscChain -> "binance-smart-chain" | |||
| Chain.ZkSync -> "zksync" | |||
| Chain.Solana -> "solana" | |||
There was a problem hiding this comment.
please check if this works with current main, because I turned off solana for coinGecko because of that. might need to be turned on again
Comment on lines
27
to
35
| Chain.Ethereum -> tokenRepository | ||
| .getTokenByContract( | ||
| chainId, contractAddress | ||
| ) | ||
|
|
||
| Chain.Solana -> splTokenRepository | ||
| .getTokenByContract(contractAddress) | ||
|
|
||
| else -> null |
There was a problem hiding this comment.
don't we support more chains?
aminsato
force-pushed
the
feat/add-custom-token-to-solana
branch
3 times, most recently
from
9a1fa25 to
fc56ba1
Compare
aminsato
force-pushed
the
feat/add-custom-token-to-solana
branch
from
fc56ba1 to
1c48d70
Compare
yvebe
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1196