Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clearFocusOnKeyboardDismiss Modifier #1214

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Remove clearFocusOnKeyboardDismiss Modifier #1214

merged 1 commit into from
Oct 21, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Oct 20, 2024 •
edited
Loading

Since BasicTextField2 has been replaced with BasicTextField, and BasicTextField with clearFocusOnKeyboardDismiss modifier causes refocusing on Android 8, the clearFocusOnKeyboardDismiss modifier has been removed.

@aminsato aminsato requested a review from yvebe October 20, 2024 10:32
yvebe
yvebe approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@yvebe yvebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@yvebe yvebe merged commit 4ad12e9 into main Oct 21, 2024
1 check passed
@yvebe yvebe deleted the fix/keyboard-refocusing branch October 21, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvebe yvebe yvebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminsato @yvebe