Add address share screen #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvebe
requested changes
May 16, 2024
|
|
||
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| fun QrAddressScreen(navController: NavHostController) { |
There was a problem hiding this comment.
Please, let's keep everything internal where possible; it'll help us to modularize the application later
app/src/main/java/com/vultisig/wallet/ui/navigation/Navigation.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/vultisig/wallet/presenter/qr_address/QrAddressScreen.kt
Outdated
Show resolved
Hide resolved
|
|
||
| Box( | ||
| Modifier | ||
| .clip(shape = RoundedCornerShape(qrBoxSize.div(10))) |
There was a problem hiding this comment.
It's probably just fixed 10.dp size of corners
There was a problem hiding this comment.
The rounded corner size is calculated based on the radius of the QR border, ensuring that it remains proportional to the size of the border. This approach prevents any extra cut of the border on devices with different screen sizes, resulting in a consistent and visually pleasing UI experience across various devices.
There was a problem hiding this comment.
And why not to fix size of the QR border at 10.dp too?
Co-authored-by: YGolybev <[email protected]>
…ddressScreen.kt Co-authored-by: YGolybev <[email protected]>
aminsato
force-pushed
the
feature/chain-address-qr-code
branch
from
7c6e762 to
430feae
Compare
yvebe
approved these changes
May 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.