Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WETH contract address on BSC #1097

Merged
merged 18 commits into from
Oct 10, 2024
Merged

Fix WETH contract address on BSC #1097

merged 18 commits into from
Oct 10, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Oct 6, 2024

No description provided.

@aminsato aminsato requested a review from yvebe October 6, 2024 08:45
@@ -566,7 +566,7 @@ object Coins {
decimal = 18,
hexPublicKey = "",
priceProviderID = "",
contractAddress = "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
contractAddress = "0x4db5a66e937a9f4473fa95b1caf1d1e1d62e29ea",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is Wormhole WETH , but on bsc chain , I think for WETH we are talking about Binance pegged WETH
https://bscscan.com/address/0x2170ed0880ac9a755fd29b2688956bd959f933f8

Copy link
Contributor

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also , you might want to consider do a db migration

@aminsato aminsato requested a review from johnnyluo October 8, 2024 08:27
@aminsato
Copy link
Contributor Author

aminsato commented Oct 8, 2024

Since threre is no WETH token on BSC, I updated logo and ticker base on Binance-Peg Ethereum Token (ETH)]

Copy link
Contributor

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvebe yvebe merged commit 8a22440 into main Oct 10, 2024
1 check passed
@yvebe yvebe deleted the fix/weth-on-bsc branch October 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants