Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict vault names #1090

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Fix conflict vault names #1090

merged 4 commits into from
Oct 15, 2024

Conversation

yevhen1sec
Copy link
Collaborator

Fixes #1088

@yevhen1sec yevhen1sec requested a review from yvebe October 4, 2024 20:39
Copy link
Collaborator

@yvebe yvebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we just don't check vault name when joining keygen, and ios does it, can you check on that? random numbers a bit tricky :)

@yevhen1sec yevhen1sec requested a review from yvebe October 11, 2024 13:00
@@ -36,7 +36,7 @@ okhttp = "4.12.0"
room = "2.6.1"
sparkCore = "2.9.4"
annotation = "1.8.2"
walletCore = "4.1.7"
walletCore = "4.0.40"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we drop down?

@@ -1,6 +1,6 @@
package com.vultisig.wallet.data.usecases

import javax.inject.Inject
import jakarta.inject.Inject
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably redundant

@yevhen1sec yevhen1sec requested a review from yvebe October 14, 2024 07:54
@yvebe yvebe merged commit 02ae182 into main Oct 15, 2024
1 check passed
@yvebe yvebe deleted the bugfix/conflict-vault-names branch October 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] conflicting vault names
3 participants