-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflict vault names #1090
Fix conflict vault names #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we just don't check vault name when joining keygen, and ios does it, can you check on that? random numbers a bit tricky :)
gradle/libs.versions.toml
Outdated
@@ -36,7 +36,7 @@ okhttp = "4.12.0" | |||
room = "2.6.1" | |||
sparkCore = "2.9.4" | |||
annotation = "1.8.2" | |||
walletCore = "4.1.7" | |||
walletCore = "4.0.40" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we drop down?
@@ -1,6 +1,6 @@ | |||
package com.vultisig.wallet.data.usecases | |||
|
|||
import javax.inject.Inject | |||
import jakarta.inject.Inject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably redundant
Fixes #1088