Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add MariaDB #414

Closed
wants to merge 3 commits into from
Closed

docs: add MariaDB #414

wants to merge 3 commits into from

Conversation

robertsilen
Copy link
Contributor

Suggesting to add MariaDB to README as mentioned in #412

@robertsilen robertsilen mentioned this pull request Aug 19, 2024
@robertsilen
Copy link
Contributor Author

Hey, any reason not to merge this?

@shino
Copy link
Contributor

shino commented Sep 24, 2024

Hey, any reason not to merge this?

This does not work. I'm afraid this PR is incomplete?

@robertsilen
Copy link
Contributor Author

Hey, any reason not to merge this?

This does not work. I'm afraid this PR is incomplete?

I tweaked it now to read MariaDB can be used instead of MySQL, but not in the parameter dbtype. Does that make sense?

@MaineK00n MaineK00n changed the title add MariaDB docs: add MariaDB Sep 24, 2024
@shino shino changed the title docs: add MariaDB doc(db): add MariaDB Sep 24, 2024
@MaineK00n MaineK00n changed the title doc(db): add MariaDB docs: add MariaDB Sep 24, 2024
@shino
Copy link
Contributor

shino commented Sep 25, 2024

Thanks for the fix!

We will merge #418 first, and will merge this PR after rebasing 🎊

@shino shino mentioned this pull request Sep 26, 2024
12 tasks
@shino
Copy link
Contributor

shino commented Sep 26, 2024

Because I need to rebase, created new PR #420 . Close this and will merge that.

@shino shino closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants